How to Fix "Cannot read property 'then' of undefined" in JS

How to fix common JavaScript errors
Ferenc Almasi β€’ 2023 May 29 β€’ Read time 3 min read
  • twitter
  • facebook
JavaScript

The "Uncaught TypeError: Cannot read properties of undefined (reading 'then')" error occurs in JavaScript whenever you try to chain a then callback from a function that doesn't return anything:

Copied to clipboard! Playground
const getPosts = () => {
    fetch('https://jsonplaceholder.typicode.com/posts')
        .then(data => data.json())
}

// ❌ This will throw: Uncaught TypeError: Cannot read properties of undefined (reading 'then')
getPosts().then(data => console.log(data))
Function without return

In the above example, we use the Fetch API to retrieve some posts from a remote REST API, and we want to consume the data inside a then callback. However, the above example will throw an error because the function doesn't return anything.


How to Fix the Error

In order to fix the error, you need to ensure that a promise is returned from the function. Put a return keyword in front of the fetch function to fix the error:

Copied to clipboard! Playground
const getPosts = () => {
    return fetch('https://jsonplaceholder.typicode.com/posts')
        .then(data => data.json())
}

// βœ”οΈ This will work as the function returns a promise
getPosts().then(data => console.log(data))
Function returning promise

In case no other logic is needed inside the function, we can omit the return keyword inside arrow functions by also removing the curly braces. The following code achieves the same result as the one above:

Copied to clipboard!
const getPosts = () => fetch('https://jsonplaceholder.typicode.com/posts')
    .then(data => data.json())
Using implicit return

Returning Promises Without Fetch

In some cases, you may need to construct a promise yourself without using the Fetch API. Let's take the following example where we return static data from a function, and we want to use a then callback:

Copied to clipboard! Playground
const post = {
    id: 1,
    title: '...',
    body: '...'
}

// ❌ This will throw the above error
const getPost = () => post

// Or using explicit return
const getPost = () => {
    return post
}

// βœ”οΈ This will ensure the value is returned as a promise
const getPost = () => Promise.resolve(post)
Using promise without fetch

In the first example, the function returns the object as-is, hence we get the same error because the return value is not a promise. To turn it into a promise without using the Fetch API, we need to call Promise.resolve, with the value that we want to resolve.

For this simple example, you don't need to use a promise. Only use this approach when you don't know the value of post upfront, and it can be either a promise or not. In such cases, Promise.resolve helps you ensure that a promise is always returned.

Looking to improve your skills? Check out our interactive course to master JavaScript from start to finish.
Master JavaScriptinfo Remove ads

Conclusion

When nothing is returned from a function, it will implicitly return undefined. We can also verify this by using the typeof operator on the invoked function:

Copied to clipboard!
const getPosts = () => {}

// This will return 'undefined'
typeof getPosts()
Functions without a return keyword will return undefined

Note that when encountering the above error, you always need to return a promise, as all promises are so-called thenables (but not all thenables are promises). A thenable is an object that implements a then method that can be chained from the object, usually a promise.

If you would like to learn more about how the Fetch API and promises work in JavaScript, make sure you check out the following lesson where we dive deeper into the API, as well as how to handle responses and errors.

How to Use the Fetch API in JavaScript
  • twitter
  • facebook
JavaScript
Did you find this page helpful?
πŸ“š More Webtips
Frontend Course Dashboard
Master the Art of Frontend
  • check Access 100+ interactive lessons
  • check Unlimited access to hundreds of tutorials
  • check Prepare for technical interviews
Become a Pro

Courses

Recommended

This site uses cookies We use cookies to understand visitors and create a better experience for you. By clicking on "Accept", you accept its use. To find out more, please see our privacy policy.